feat: NVSHAS-9501 support SLSA #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holyspectral
force-pushed
the
slsa
branch
4 times, most recently
from
ee2f22a to
550d111
Compare
pjbgf
reviewed
Nov 15, 2024
pjbgf
approved these changes
Nov 28, 2024
holyspectral
force-pushed
the
slsa
branch
4 times, most recently
from
6f5d358 to
6c39ced
Compare
1. Provide cross-platform/standalone Dockerfile 2. Release.yml to publish SLSA-capable artifacts 3. Provide build target, test-image, build-image and push-image to sync with rancher. 4. Switch to golang:1.22 as its base image
pjbgf
reviewed
Dec 13, 2024
Comment on lines
+8
to
+11
| COPY config/ /src/config | ||
| COPY server/ /src/server | ||
| COPY vendor/ /src/vendor | ||
| COPY go.mod go.sum adapter.go version.go Makefile /src |
There was a problem hiding this comment.
This could be optimised so that the Go mod download leverages Docker caching. Feel free to change that in that follow-up PR.
pjbgf
approved these changes
Dec 13, 2024
BinX-Suse
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement standalone Dockerfile and corresponding GHA to support SLSA L3.