Merge pull request #424 from holyspectral/fix-cronjob

Fix an issue where cert-upgrader pod created by cronjob has no effect
neuvector · Aug 22, 2024 · 02c44af · 02c44af
2 parents 7b1abaf + 6876d05
commit 02c44af
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/charts/core/templates/controller-deployment.yaml b/charts/core/templates/controller-deployment.yaml
@@ -98,10 +98,6 @@ spec:
           env:
             - name: OVERRIDE_CHECKSUM
               value: {{ dict "image" (include "neuvector.controller.image" .) "internal" .Values.internal "certupgrader" .Values.controller.certupgrader | toJson | sha256sum }}
-            {{- if and .Values.internal.autoRotateCert (not $pre540) }}
-            - name: ENABLE_ROTATION
-              value: "1"
-            {{- end }}
           {{- with .Values.controller.certupgrader.env }}
 {{- toYaml . | nindent 12 }}
           {{- end }}

diff --git a/charts/core/templates/upgrader-cronjob.yaml b/charts/core/templates/upgrader-cronjob.yaml
@@ -73,6 +73,9 @@ spec:
               command: 
                 - /usr/local/bin/upgrader
                 - upgrader-job
+              {{- if and .Values.internal.autoRotateCert }}
+                - --enable-rotation
+              {{- end }}
               env:
               {{- with .Values.controller.certupgrader.env }}
 {{- toYaml . | nindent 14 }}