Add t-statistic images as valid targets in ImageTransformer

[JulioAPeraza]

Closes None.

Changes proposed in this pull request:

• Add t-statistic images as valid targets in ImageTransformer

Summary by Sourcery

Add support for t-statistic images as valid targets in the ImageTransformer and include corresponding tests to ensure proper functionality.

New Features:

• Add support for t-statistic images as valid targets in the ImageTransformer.

Tests:

• Add tests to verify the transformation of t-statistic images in ImageTransformer.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds support for t-statistic images as valid targets in the ImageTransformer class. The changes include updating the valid_targets set in nimare/transforms.py to include 't' and adding test cases in nimare/tests/test_transforms.py to validate the new functionality.

File-Level Changes

Files	Changes
nimare/tests/test_transforms.py nimare/transforms.py	Added support for t-statistic images in ImageTransformer and included corresponding test cases.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @JulioAPeraza - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a specific test to verify that t-statistic images are correctly transformed by the ImageTransformer.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Testing: 2 issues found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (testing): Check for correct transformation.

Consider adding assertions to check that the transformation of 't' images is correct, not just that the lists match.

Suggested change

	new_t_files = new_dset.images["t"].tolist()
	new_t_files = new_dset.images["t"].tolist()
	for old, new in zip(t_files, new_t_files):
	assert old != new, "Transformation didn't change the image path"
	assert new.endswith('.nii.gz'), "Transformed image should be in NIfTI format"
	assert len(t_files) == len(new_t_files), "Number of images should remain the same"

[sourcery-ai]

suggestion (testing): Clarify the purpose of the assertion.

The assertion assert t_files[:-1] == new_t_files[:-1] is not immediately clear. Consider adding a comment to explain why the last element is excluded from the comparison.

Suggested change

	assert t_files[:-1] == new_t_files[:-1]
	assert t_files[:-1] == new_t_files[:-1], "Transformed t_files should match original, except for the last element"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (1dd2a34) to head (5854655).
Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files          48       48           
  Lines        6386     6386           
=======================================
  Hits         5635     5635           
  Misses        751      751           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jdkent]

LGTM!