-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] initial add of jupyterlite #785
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
- Coverage 88.65% 87.95% -0.71%
==========================================
Files 41 42 +1
Lines 4752 4807 +55
==========================================
+ Hits 4213 4228 +15
- Misses 539 579 +40
☔ View full report in Codecov by Sentry. |
need to think about how to add dependencies to the python package: |
I was trying to create an environment to load the pyodide kernel in Jupytelite, but we ran out of memory in RTD. |
We also rely on nilearn for running the examples, which is not part of the pyodide kernel. Installing nilearn and nimare for running the notebook will take a lot of time. |
I'm curious if we can build our own pyodide distribution in a github action and load the built/packaged pyodide in readthedocs? |
|
Installing the env using mamba seems to solve the memory issue in RTD but it looks like |
I have been trying to install a nimare wheel in pyodide, but some of the dependencies don't have a wheel available. For the nimare wheel available in Pypi I got this error:
And for the wheel created by this PR using a github action, I got this error:
The dependency with |
We will also need to find a server to host the pyodide wheel because they cannot be uploaded to PyPi: https://pyodide.org/en/stable/development/building-and-testing-packages.html#notes |
Alternatively, we can leave the |
I am in support of trying to make nimare pure python if the only non-pure dependency is |
Sounds good. |
At least now we don't get the error with cognitiveatlas. I will be able to test the build again once #796 gets merged. |
I think the numba issue is going to be non-trivial Unfortunately, I would consider this to be blocking since we depend on numba for sparse and sparse is essential for optimizing several core workflows for running meta-analyses. |
I subscribed to the relevant issues to keep track on updates to this, but since this cannot be worked on for the forseeable future, I'm closing this pull request. |
Closes #784 .
Changes proposed in this pull request: