-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document napari plugin #393
Open
niksirbi
wants to merge
8
commits into
napari-dev
Choose a base branch
from
document-napari-plugin
base: napari-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## napari-dev #393 +/- ##
===========================================
Coverage 99.82% 99.82%
===========================================
Files 18 18
Lines 1122 1172 +50
===========================================
+ Hits 1120 1170 +50
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Closes #283
What does this PR do?
This PR puts some final necessary touches before we are able to release the
napari
plugin into the world.napari-video
andpyvideoreader
to the[napari]
extras dependencies. These are necessary for loading videos into as an image layer innapari
.movement
plugin for napari. This guide includes some warnings, to manage expectations, and some advice on how to troubleshoot video playback issues.napari
at hifgh fps, I modified the default behaviour of the plugin. Previously, the plugin changednapari
's playback fps setting to the same value as the loaded data (e.g. if loading data tracked at 60 fps, the plugin would automatically setnapari
's palyback speed to that values, so that the video would play "in real time" by default). This PR removes that feature, and instead leaves that choice entirely to the user (documented in the guide). This means that user's will getnapari
's default playback rate of 10 fps, and can choose to change that however they like.References
After this PR is successfully merged into
napari-dev
, we will have achieved all tasks listed under the meta-issue #31.After that, we can finally merge
napari-dev
intomain
, write a blogpost about the plugin and finally make ourv0.1.0
release.How to review this PR
The best way to review the PR would be to build the docs locally, and then follow the instructions in updated docs, i.e.:
movement
in dev mode (this also gets you all thenapari
-related dependenciesds = sample_data.fetch_dataset(filename, with_video=True)
, and find the files in~/.movement
.The reason I'm tagging many reviewers here is the following:
napari
plugin development, so I thought y'all will benefit from seeing the current (limited) status quo.napari
.How has this PR been tested?
No new functionality has been added. Some tests were modified to account for the removal of the aforementioned fps functionality.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
It is, for the most part, an update to documentation.
Checklist: