moving deduplication of log_sensor_file outside the loop #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwhite1
reviewed
Oct 31, 2023
| for i in x: | ||
| c = c+str(i) | ||
| return c | ||
| # Convert an array of filenames into a single concatenated string. If order of filename array |
There was a problem hiding this comment.
Could this be addressed by sorting here? Assuming the file name list isn't too long it might not be expensive.
There was a problem hiding this comment.
The table structure is such that the file names are a list in a single cell - i.e. postgresql datatype of text[]. The list itself contains very few file names, often just one. For any sort operation in the filenames, they will still need to be unpacked. I chose this route since the apply() and drop_duplicates() methods are efficiently implemented in pandas. I think sorting on another column and then selecting unique lists of file names would also work.
lwhite1
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was passing instance of the log_sensor_file table to the write_file_into function inside dataflow. For each call, the function would query the table and execute code to deduplicate the table. This happens 850 times nightly and the number will grow with as session folders grow. The table only needs to be queried and deduplicated once. That change is implemented in this PR. FYI function call times are:
Querying and dedup 10 times: 31.17 seconds
Querying once and dedup 10 times: 6.26 seconds
Querying once and dedup one time: 2.58 seconds