Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse db connections and ensure closing #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lwhite1
Copy link
Contributor

@lwhite1 lwhite1 commented Jan 14, 2025

Reuse open database connections where possible and ensure that they are closed by using 'with' to open them.

Note: it looks like there are a lot of changes, but all but a few are indentation changes resulting from replacing:

conn = meta.get_database_connection()

with

with meta.get_database_connection() as conn:

@lwhite1 lwhite1 requested a review from divyadk January 14, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant