-
Notifications
You must be signed in to change notification settings - Fork 50
Add container build jobs to all build workflows #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cd53d14
to
9f72b0f
Compare
📦 Build Artifacts Available |
9f72b0f
to
7f29432
Compare
📦 Build Artifacts Available |
7f29432
to
fc1b3b2
Compare
fc1b3b2
to
9b3e87c
Compare
📦 Build Artifacts Available |
9b3e87c
to
23f64b9
Compare
📦 Build Artifacts Available |
23f64b9
to
0bbaf03
Compare
📦 Build Artifacts Available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds container build jobs to the existing build workflows, enabling container image builds and pushes alongside the wheel builds.
- Added a new job "build-and-push-container" in the release, release-candidate, nightly, and development workflows.
- Configured different container image tag strategies based on the workflow context.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/release.yml | Introduces container build and push job with tags "latest stable". |
.github/workflows/release-candidate.yml | Adds container build step with tag "latest". |
.github/workflows/nightly.yml | Implements a container job with the "nightly" tag. |
.github/workflows/development.yml | Creates a container build job using a PR-based tag. |
📦 Build Artifacts Available |
2776f6c
to
f0ebe02
Compare
📦 Build Artifacts Available |
Add container build jobs alongside the existing wheel jobs. Tag containers based on which workflow was triggered.
Tags:
pr-{{ github.event.number }}
{{ github.sha }}
nightly
{{ github.sha }}
latest
{{ github.sha }}
latest
stable
{{ github.sha }}
Edit: To save space, don't use unique tags.
Future Improvements (Follow up PR)