Skip to content

Commit

Permalink
Make dune constraint consistent
Browse files Browse the repository at this point in the history 
Ref: ocaml/opam-repository#24319 (comment)
  • Loading branch information
@mattxwang
mattxwang committed Oct 4, 2023
1 parent 6e6a1b0 commit fc2965d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dune-project
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
(source (github neuppl/rsdd-ocaml))
(depends
(ocaml (and (>= "4.08.0") (< "5")))
(dune (>= "3.0"))
(dune (>= "2.7"))

This comment has been minimized.

Sign in to view

Copy link
@haochenx

haochenx Oct 5, 2023

It's actually better to have just

  dune

so the generated opam file won't have redundant constraint clause. (sorry for not being clear earlier..)

This comment has been minimized.

Sign in to view

Copy link
@mattxwang

mattxwang Oct 5, 2023

Author Member

Oh no worries at all! I'm new to the opam & dune ecosystem, so all of these pointers are quite helpful. Appreciate you taking a look at this!
conf-rust-2021))
2 changes: 1 addition & 1 deletion rsdd.opam
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ homepage: "https://github.com/neuppl/rsdd-ocaml"
bug-reports: "https://github.com/neuppl/rsdd-ocaml/issues"
depends: [
"ocaml" {>= "4.08.0" & < "5"}
"dune" {>= "2.7" & >= "3.0"}
"dune" {>= "2.7" & >= "2.7"}
"conf-rust-2021"
"odoc" {with-doc}
]
Expand Down

0 comments on commit fc2965d

Please sign in to comment.