Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the graph coloring #80

Closed
wants to merge 1 commit into from

Conversation

unna97
Copy link

@unna97 unna97 commented May 13, 2022

This is a work in progress branch with respect to issue #77

@unna97
Copy link
Author

unna97 commented May 13, 2022

@MridulS @rossbar @dschult This is my first time creating a .md file from .ipynb. There are interactive visualizations in the notebook, is that okay?

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to take a look at this but then was struck by the size of the greedy_colouring.md file - it's 36 MB! This is absolutely huge for a text file - I think there is a ton of embedded html that should be removed, but I don't have a good sense for how to do so nor how this file was created.

Either way, this will be the first bridge to cross before it's even possible to review the file!

@unna97
Copy link
Author

unna97 commented Jun 15, 2022

@rossbar Thank you for the feedback. I created interactive maps using folium for demonstration of four colour map theorem. I think that would be the biggest file. Would you like me to remove it?

@navyagarwal navyagarwal mentioned this pull request Feb 9, 2023
2 tasks
@rossbar
Copy link
Contributor

rossbar commented Apr 9, 2023

I'm going to go ahead and close this one since it's been stale for a while. That's not to say a coloring example wouldn't be a valuable addition. @unna97 if you're still interested in pursuing this, please start by removing the embedded html from the notebook to get this into a reviewable form, then please feel free to reopen!

@rossbar rossbar closed this Apr 9, 2023
@unna97
Copy link
Author

unna97 commented Apr 10, 2023

@rossbar sure, will make changes and update soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants