Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #124

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Update index.md #124

merged 2 commits into from
Jan 5, 2024

Conversation

squenson1
Copy link
Contributor

Make the spelling of "indegree" consistent:
"in-degree" --> "indegree"

Make the spelling of "indegree" consistent:
"in-degree" --> "indegree"
@dschult
Copy link
Member

dschult commented Jan 4, 2024

Consistent with what? What are you matching with?

@squenson1
Copy link
Contributor Author

"Consistent" meaning one spelling or the other, not both in such a short text, it is very confusing (even if both seems to be accepted in the literature).

@rossbar
Copy link
Contributor

rossbar commented Jan 5, 2024

FWIW I think we should actually go the opposite direction, i.e. "indegree" -> "in-degree". The reason being consistency with NetworkX itself, which clearly favors the latter spelling. You can verify this with grep:

# In the networkx source repo
$ grep -rIo "indegree" | wc -l
30
$ grep -rIo "in-degree" | wc -l
58

All of the instances of indegree are variable names in code, so in-degree is the clear winner for documentation!

@squenson1
Copy link
Contributor Author

Fine for me, one spelling or the other but not both!

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @squenson1 !

@rossbar rossbar merged commit 6041e6a into networkx:main Jan 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants