feat: Identify datasets by their URI #1426
Conversation
ddeboer
force-pushed
the
1423-dataset-uri
branch
from
b2ffd74
to
a44e1a7
Compare
BREAKING CHANGE: terminology sources are no longer identifier by their distribution URI. Keep BC by still allowing the distribution URI to be used when searching. However, the sources query now returns source instead of distribution URIs.
ddeboer
force-pushed
the
1423-dataset-uri
branch
from
8522429
to
17a88a6
Compare
* Consistently identify variants with hash (#) instead of slash (/). BREAKING CHANGE: terminology sources are no longer identifier by their distribution URI. Keep BC by still allowing the distribution URI to be used when searching. However, the sources query now returns source instead of distribution URIs.
ddeboer
force-pushed
the
1423-dataset-uri
branch
from
17a88a6
to
40281e8
Compare
|
As long as we continue both distribution and source ID for the time being it looks good to me as well. In the longer run we should communicate the move to dataset ID's first before phasing out distribution ID's. Just to be sure, this PR does not result in a breaking change, right? |
There’s no breaking change for clients when sending queries as they can continue to use the distribution URI as before. However, there may be a breaking change for clients when reading the results, if they want to match the URIs from results with multiple terminology sources with the distribution URIs they used when sending the query. However, the results also contain each source’s name, so I’m hoping that’s not a serious break. |
ddeboer
changed the title
ddeboer
force-pushed
the
1423-dataset-uri
branch
from
e1e8dbf
to
290886f
Compare
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.16.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Fix #1423
Terminology sources are no longer identifier by their distribution URI.
Keep BC by still allowing the distribution URI to be used when searching.
The sources query now returns the new source instead of distribution URIs.