feat: Introduce config object to wrap env var lookups (#1279)

netwerk-digitaal-erfgoed · Mar 18, 2024 · d1ae2dd · d1ae2dd
1 parent b50fe83
commit d1ae2dd
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 2 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/network-of-terms-query/package.json b/packages/network-of-terms-query/package.json
@@ -39,6 +39,7 @@
     "@opentelemetry/sdk-metrics": "1.22.0",
     "@opentelemetry/semantic-conventions": "1.22.0",
     "@rdfjs/data-model": "^2.0.2",
+    "env-schema": "^5.2.1",
     "joi": "^17.12.2",
     "pino": "^8.19.0",
     "pino-pretty": "^10.3.1",

diff --git a/packages/network-of-terms-query/src/config.ts b/packages/network-of-terms-query/src/config.ts
@@ -0,0 +1,24 @@
+import {envSchema, JSONSchemaType} from 'env-schema';
+
+const schema = {
+  type: 'object',
+  properties: {
+    MAX_QUERY_TIMEOUT: {
+      type: 'number',
+      default: 60000,
+    },
+    DEFAULT_QUERY_TIMEOUT: {
+      type: 'number',
+      default: 5000,
+    },
+  },
+};
+
+interface Env {
+  MAX_QUERY_TIMEOUT: number;
+  DEFAULT_QUERY_TIMEOUT: number;
+}
+
+export const config: JSONSchemaType<Env> = envSchema({
+  schema,
+});
diff --git a/packages/network-of-terms-query/src/query.ts b/packages/network-of-terms-query/src/query.ts
@@ -12,6 +12,7 @@ import {QueryEngine} from '@comunica/query-sparql';
 import {BindingsFactory} from '@comunica/bindings-factory';
 import {DataFactory} from 'rdf-data-factory';
 import {sourceQueriesHistogram} from './instrumentation.js';
+import {config} from './config.js';
 
 export type TermsResult = Terms | TimeoutError | ServerError;
 
@@ -102,8 +103,8 @@ export class QueryTermsService {
       Joi.number()
         .integer()
         .min(1)
-        .max(parseInt(process.env.MAX_QUERY_TIMEOUT as string) || 60000)
-        .default(parseInt(process.env.DEFAULT_QUERY_TIMEOUT as string) || 5000)
+        .max(config.MAX_QUERY_TIMEOUT)
+        .default(config.DEFAULT_QUERY_TIMEOUT)
     );
 
     const timer = new Hoek.Bench();