Unify system variable $basePath #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormalization of this method and removing ending slash
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in implementation of system variable $basePath in Nette + Latte. The variable is created in UrlScript::getBasePath() with ending slash. But in Latte/MicroPresenter is used WITHOUT this ending slash - this is tricky. The purpose of this PR is unify $basePath in all nette packages to have everywere identical value.
Variable $basePath is used in 3 nette packages in 5 classes:
nette/application
nette/routing
nette/http
there are 3 separate PR for every package, to be merger all together:
#18
nette/http#242
nette/application#341
I will also publish on forum nette more deep explanation of this RFC.
This PR is a BC break, but the existing "dichotomy" between value in Latte and UrlScript is much worse. Therefore, I recommend unify the value of $basePath regardless of the BC break.