Support for properties in NEON statement syntax in section services - PART 1 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od (BC break)" This reverts commit 87662eb.
added Definition::getDescriptor(), Helpers::entityToString()
…r(), convertReferences() - extend support for @service::Constant/$staticProperty
…eck of existence of the constant, add converting constant/static property to Literal object
…ents to syntax with $property, $$staticProeprty, $Constant and method - to creater arguments + setup items.
dg
force-pushed
the
master
branch
2 times, most recently
from
8655bcb to
59cf699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple bugs in compiling neon statements - service arguments/setup into php code in container - support of properties/constants syntax is unsufficient. This was discussed on forum here with detailed list of invalid compiling variants:
https://forum.nette.org/cs/36724-chyby-v-konfiguraci-syntaxe-property-konstanty-v-sekci-services-aktualizace
I made deep testing and found 6 bugs in the statement syntax. I have developed and tested fix of all bugs, which involves changes in 8 classes in nette/di, nette/neon and nette/application. Beside this PR 1, I submitted anoither two PR, all of them should be merged together:
PR2 https://github.com/…neon/pull/73
PR3 https://github.com/…ion/pull/339
Today I published detailed description of the solution + detailed tests on forum here:
https://forum.nette.org/cs/36724-chyby-v-konfiguraci-syntaxe-property-konstanty-v-sekci-services-aktualizace#p228053
Tests are 100% succesfull so I hope everything was done for succesfull merging.