-
-
Notifications
You must be signed in to change notification settings - Fork 70
DI config: add spread operator #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matej21
wants to merge
1
commit into
nette:master
Choose a base branch
from
matej21:feature/spread-operator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9ed939
to
0891cbd
Compare
0891cbd
to
e10cee9
Compare
For accuracy: it is not like PHP spread operator, because it works with keys, so |
4243866
to
e8187b3
Compare
It would be fine merge it or reject it. What do you think? I could be the fine feature in Nette 3? |
e78d4c1
to
b36d041
Compare
ec720a7
to
9d3541e
Compare
8224b32
to
d51ca9e
Compare
1fc7645
to
485a875
Compare
a27a10b
to
594a33a
Compare
680bc12
to
5066242
Compare
b109822
to
7f11e6e
Compare
ef39d2d
to
f729b1e
Compare
a43bb2c
to
71a91be
Compare
51cfed7
to
9c4af52
Compare
0a1f0ab
to
8c392ab
Compare
96c09bc
to
7a40f39
Compare
8655bcb
to
59cf699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
with a scalar parameter. it could be fixed by checking whether return value is an array, but is it worth it?)