SqlBuilder: Fixed joinWhere with aliases and .tables #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? [$table => $this->parameters['joinCondition'][$this->reservedTableNames[$table]]] | ||
| : []; | ||
|
|
||
| if (array_key_exists($table, $this->aliases)) { |
There was a problem hiding this comment.
is needed array_key_exist? isset($this->aliases[$table]) is faster
dg
force-pushed
the
master
branch
13 times, most recently
from
44a230d to
829b936
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
b74e9fb to
b2e321a
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
e249c62 to
d56890f
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
e95a595 to
0b4d2e5
Compare
dg
force-pushed
the
master
branch
29 times, most recently
from
a329d1b to
9f82d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.