-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added RejectedRequestException #173
Open
dg
wants to merge
1
commit into
nette:master
Choose a base branch
from
dg:reject
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
referenced
this pull request
Jan 26, 2017
…stead BadRequestException when incompatible type is object
dg
force-pushed
the
v2.4
branch
2 times, most recently
from
January 26, 2017 17:18
30b8609
to
97edb43
Compare
dg
force-pushed
the
reject
branch
2 times, most recently
from
January 27, 2017 01:39
dedb5e5
to
4e07a2d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 2, 2017 02:44
88ef0bd
to
b7df270
Compare
dg
force-pushed
the
master
branch
10 times, most recently
from
July 12, 2017 14:09
8dabc1a
to
2e29386
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 8, 2024 21:03
e3d05b3
to
929a242
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
March 11, 2024 20:02
426e735
to
c19ebdc
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
April 7, 2024 02:51
2b9da37
to
30d90f4
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
April 20, 2024 00:46
bf86204
to
c91f90a
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
May 2, 2024 10:37
57bd587
to
e908315
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
May 13, 2024 09:25
c5ecbda
to
ecb200c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that framework rejects request, it throws
RejectedRequestException
instead ofBadRequestException
orBadSignalException
. TheBadSignalException
should be deprecated in future.The main reason is to reach finer granularity for BadRequestException exception.
The naming should be discussed. Is better RejectRequestException or RejectedRequestException? What about constants in RejectedRequestException?
ping @JanTvrdik @matej21