Interface IRouteMeta define API for RoutingPanel. #114
Conversation
src/Application/IRouteMeta.php
Outdated
| * Return route mask. | ||
| * @return string | ||
| */ | ||
| public function getMask(); |
There was a problem hiding this comment.
Nette doesn't use visibility in interfaces.
|
I don't like the name, it sounds like an abbreviation. :/ |
|
@Majkl578 What do you suggest? I named in issue as IRouteBar. What do you think about IRouteInfo, IRouteMask, IRouteMaskBar, IRoutingPanelRoute? |
|
Generally good idea but the issue is much more complex. |
dg
force-pushed
the
master
branch
2 times, most recently
from
20a93ca to
08cbdeb
Compare
|
@JanTvrdik Let's describe it. |
|
You need to consider custom routers (which can do pretty much anything) as well. Some custom routers may be just wrappers of another routers, some do complex logic. The entire interface of routing bar may need to be redesigned to be able to clearly display advanced router configurations. For start it needs to support tree of routers, not a list. |
|
@JanTvrdik You are true, but I think this is good step forward. |
dg
force-pushed
the
master
branch
10 times, most recently
from
2c1ae3b to
b42b3fe
Compare
dg
force-pushed
the
master
branch
9 times, most recently
from
8e388e3 to
aca6b40
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
88ef0bd to
b7df270
Compare
dg
force-pushed
the
master
branch
13 times, most recently
from
3187c71 to
1eeffdf
Compare
dg
force-pushed
the
master
branch
12 times, most recently
from
8e1f517 to
2f545e6
Compare
Issue #113