Skip to content

Conversation

OlivierCazade
Copy link
Contributor

@OlivierCazade OlivierCazade commented Sep 23, 2025

Description

Operator-sdk now overwrite the bundle.Dockerfile, this PR disable it.

Metadata and manifest directory are not impacted since they are deleted before generating the bundle.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

openshift-ci bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.60%. Comparing base (6b872b1) to head (3012ca5).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
+ Coverage   71.53%   71.60%   +0.07%     
==========================================
  Files          80       80              
  Lines       10641    10641              
==========================================
+ Hits         7612     7620       +8     
+ Misses       2627     2622       -5     
+ Partials      402      399       -3     
Flag Coverage Δ
unittests 71.60% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OlivierCazade OlivierCazade added the needs-review Tells that the PR needs a review label Sep 24, 2025
@jotak
Copy link
Member

jotak commented Sep 25, 2025

/lgtm

The downside is to lose automated metadata updates, but I guess that's ok because they don't change so often, they're partly overwritten anyway (for downstream builds), and, well, we can perhaps refine the approach later if we hit an issue.

@openshift-ci openshift-ci bot added the lgtm label Sep 25, 2025
@jotak jotak removed the lgtm label Sep 25, 2025
@jotak
Copy link
Member

jotak commented Sep 25, 2025

/hold
discussed with @OlivierCazade , we actually don't need that
it was initially to fix #1415 but instead of editing the generated dockerfile, we can pass --label via the build command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold lgtm needs-review Tells that the PR needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants