Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 26, 2025

Some build time optimization
On my machine, webpack build going from 138s down to 52s

Copy link

openshift-ci bot commented Sep 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kalmanmeth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak requested a review from jpinsonneau October 1, 2025 12:53
@jotak jotak added the needs-review Tells that the PR needs a review label Oct 1, 2025
@jotak
Copy link
Member Author

jotak commented Oct 1, 2025

/retest

Copy link

openshift-ci bot commented Oct 2, 2025

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress 390c534 link true /test plugin-cypress

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau
Copy link
Contributor

Should we rely on process.env.NODE_ENV === 'production' for such changes and have a build:production in package.json ?

@jotak
Copy link
Member Author

jotak commented Oct 8, 2025

@jpinsonneau why would it be only for prod? It seems good in both cases, no?

Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.20%. Comparing base (418cd67) to head (390c534).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1049   +/-   ##
=======================================
  Coverage   53.20%   53.20%           
=======================================
  Files         205      205           
  Lines       11115    11115           
  Branches     1295     1295           
=======================================
  Hits         5914     5914           
  Misses       4689     4689           
  Partials      512      512           
Flag Coverage Δ
uitests 55.97% <ø> (ø)
unittests 47.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Tells that the PR needs a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants