Add opentelemetry instrumentation to blobs methods #338
Conversation
We already buffer stdout. This makes for nicer testing and debugging and will work well with a unikraft log collector
| const message = (error as Error).message ?? 'problem' | ||
| span.setStatus({ | ||
| code: SpanStatusCode.ERROR, | ||
| message, | ||
| }) | ||
| span.recordException(error as Error) | ||
| throw error |
There was a problem hiding this comment.
SugaredTracer we get from @netlify/otel will already automatically handle recording errors ( https://github.com/open-telemetry/opentelemetry-js/blob/41ba7f57cbf5ae22290168188b467e0c60cd4765/api/src/experimental/trace/SugaredTracer.ts#L19-L24 )
| export type BlobResponseType = 'arrayBuffer' | 'blob' | 'json' | 'stream' | 'text' | ||
|
|
||
| export class Store { | ||
| private client: Client | ||
| private name: string | ||
| private span: Span | null = null |
There was a problem hiding this comment.
I know this currently unused, but generally you wouldn't want to store a span like that because single blobs store can have multiple concurrent operations going on and this wouldn't work for such scenarios.
If you need to get some active span - https://opentelemetry.io/docs/languages/js/instrumentation/#get-the-current-span is the way to go (not sure if @netlify/otel expose it or not, but if needed could be added there). That uses async_hooks to propagate active context/span through concurrent async hell
There was a problem hiding this comment.
thanks, i will look into that api
No description provided.