feat(vite-plugin): promote build options to experimental - #32
Merged
Conversation
The `build` options were annotated `@private` with "DO NOT USE", but they are what SolidStart 2 and TanStack Start projects use to deploy without a framework-specific adapter. Mark them `@experimental` and document them in the README so the annotation matches how they're used. The build implementation isn't TanStack-specific, so update the supported-frameworks note to include SolidStart 2. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LSiikE36SgrpS184fepX7Q
✅ Deploy Preview for angular-runtime-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Vite plugin documentation now describes experimental Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1bc6f11b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
serhalp
commented
Aug 5, 2026
serhalp
commented
Aug 5, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/vite-plugin/README.md`:
- Around line 49-51: Remove the undocumented `build.edgeSSR` option from the
README unless the build implementation is updated to honor it. If retaining the
option, update the build configuration and output path logic so `build.edgeSSR:
true` deploys the SSR handler as a Netlify Edge Function rather than always
writing `.netlify/v1/functions/server.mjs`.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b60bfbca-fa99-4456-ab75-0d3dc07da00d
📒 Files selected for processing (2)
packages/vite-plugin/README.mdpackages/vite-plugin/src/main.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
netlify/blueprints(manual)
serhalp
commented
Aug 5, 2026
serhalp
changed the title
build options to experimental
The suggestion that removed the `build.edgeSSR` bullet replaced only the first of its two wrapped lines, leaving `Functions` dangling as a continuation of the `build.enabled` bullet. This failed `prettier --check`, which wanted to fold it into the line above. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LSiikE36SgrpS184fepX7Q
hrishikesh-k
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
buildoptions onNetlifyPluginOptionswere annotated@privatewith "DO NOT USE - build options, not meant for public use at this time", and weren't mentioned in the README. This is because it was only used "internally" by@netlify/vite-plugin-tanstack-start, until now.As this will now be the recommended configuration for SolidStart 2 apps, this PR swaps
@privatefor@experimentaland documents the options in the README.Changes
@private->@experimentaland adjust comment.