Skip to content

Comments

fix(deps): remove stream utils#7120

Merged
serhalp merged 15 commits intonetlify:mainfrom
v1rtl:remove-stream-utils
Apr 15, 2025
Merged

fix(deps): remove stream utils#7120
serhalp merged 15 commits intonetlify:mainfrom
v1rtl:remove-stream-utils

Conversation

@v1rtl
Copy link
Contributor

@v1rtl v1rtl commented Mar 20, 2025

🎉 Thanks for submitting a pull request! 🎉

Summary

See e18e/ecosystem-issues#156

Removes is-stream, from2-array, through2-filter, flush-write-stream and through2-map in favor of built-in stream utils


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@v1rtl v1rtl requested a review from a team as a code owner March 20, 2025 23:17
@v1rtl v1rtl changed the title Remove stream utils fix(deps): remove stream utils Mar 20, 2025
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I rebased this and fixed up a few weeks of conflicts, and tested the ntl deploy flows locally to be extra safe. Thank you!

Copy link
Contributor

@ndhoule ndhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert the is-stream changes, otherwise looks good to me.

@talentlessguy Thanks for getting this PR started, and thanks @serhalp for finishing it up!

@serhalp serhalp requested a review from ndhoule April 15, 2025 19:40
@serhalp serhalp enabled auto-merge (squash) April 15, 2025 22:01
@serhalp serhalp merged commit 5fef8d6 into netlify:main Apr 15, 2025
52 checks passed
@v1rtl v1rtl deleted the remove-stream-utils branch April 16, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants