feat: add header to installing extension with the build mode so we know where the installation is coming from #6478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2025 15:42
…ow where the installation is coming from
| @@ -32,6 +35,7 @@ export const installExtension = async ({ | |||
| }), | |||
| headers: { | |||
| 'netlify-token': netlifyToken, | |||
| 'User-Agent': extensionInstallSource, | |||
There was a problem hiding this comment.
So the user agent will be 'buildbot' | 'cli' | 'require'? For future-proofness, do we want to be a bit more descriptive and include the fact that we're calling from Netlify Build, potentially including the version?
There was a problem hiding this comment.
hmm yeah, it's not always netlify build though, could be the call to netlify config they do (we still have the double call thing)
There was a problem hiding this comment.
I'd suggest something like:
User-Agent: Netlify Build (mode:${extensionInstallationSource}) / ${buildVersion}
If there's any other arbitrary metadata that might be useful to us later in analysis, we can include it semicolon-delimited in the parenthetical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This adds a user agent header to our installation of auto-installable extensions.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)