NGSTACK-998 upgrade bundle to ibexa version 5 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 16, 2025 16:16
emodric
reviewed
Oct 17, 2025
| use function explode; | ||
| use function implode; | ||
| use function trim; | ||
| use function mb_trim; |
Member
There was a problem hiding this comment.
mb_trim is only available in PHP 8.4. So we should disable this CS fixer rule and revert to using trim.
emodric
reviewed
Oct 17, 2025
| "require-dev": { | ||
| "phpunit/phpunit": "^9.0" | ||
| "phpunit/phpunit": "^12.0", | ||
| "symfony/form": "^7.3", |
Member
There was a problem hiding this comment.
Why do we need these in require-dev ?
Contributor
Author
There was a problem hiding this comment.
phpunit/phpunit bundle is just updated to a higher version and symfony/form is added because it is used in several classes in the bundle - FieldValueTransformer, ContentTypeListFieldType, FormMapper, etc. (the Symfony\Component\Form\... use statement)
Member
There was a problem hiding this comment.
symfony/form should be then moved to require.
Contributor
Author
There was a problem hiding this comment.
651c8e0
Moved the symfony/form bundle to require section of the composer.json file.
…ion into 'require' section of 'composer.json' file
Member
|
Thanks @AntePrkacin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded bundle to use Ibexa version 5.
Made small changes to code (because of PHP8).
Modified
phpunit.xmlfile to newer version and bumped the PHP and Symfony versions intests.ymlworkflow.