Skip to content

Fix popover unit header and exponential value scaling#218

Merged
novykh merged 2 commits into
mainfrom
fix/popover-unit-header-exponential-values
Jul 13, 2026
Merged

Fix popover unit header and exponential value scaling#218
novykh merged 2 commits into
mainfrom
fix/popover-unit-header-exponential-values

Conversation

@ktsaou

@ktsaou ktsaou commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the visible Unit popover header while preserving the value/unit grid alignment
  • switch exponential values to normalized, unprefixed base-unit conversion
  • share and cache number formatting so value and unit selection use the same exponential threshold
  • cover raw, pre-scaled binary, and popover rendering cases

Verification

  • yarn test --runInBand
  • yarn test --runInBand --coverage=false src/sdk/makeChart/index.test.js src/helpers/unitConversion/getConversionUnits.test.js src/components/line/popover/dimensions.test.js
  • changed-file ESLint
  • yarn build
  • yarn build-storybook (passes with existing bundle-size warnings)

@ktsaou ktsaou marked this pull request as ready for review July 10, 2026 15:11
@novykh novykh merged commit 15c3998 into main Jul 13, 2026
2 checks passed
@novykh novykh deleted the fix/popover-unit-header-exponential-values branch July 13, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants