Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SLPF rule target reference #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-joyce
Copy link

@r-joyce r-joyce commented Sep 26, 2019

Problem: If you select the "slpf:rule_number" as the target, the reference cannot be found in the definitions section of the command.json file. This results in an error in the console and doesn't populate the target specific options.

Solution: While not the most elegant solution, I added a check for that specific case and modifies it to the proper reference.

I also noticed that you had this issue with the "command" target and that your version of command.json differs from the one in bberliner's repository slightly to account for that. So I also added a check for what the original command.json file uses (still works with your modified version), so now you should also be able to use an unmodified version of command.json.

If you'd rather handle this in a different way, feel free to deny this PR.

Thanks for making such a great tool! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant