Skip to content

Conversation

991jo
Copy link
Contributor

@991jo 991jo commented Oct 4, 2025

Fixes: #20499

@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team October 7, 2025 12:31
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc additions, @991jo . It's much appreciated!

I made some notes here and below:

  1. Let's clarify that the "Quick Search" field is the UI field, not the field in the filter or the method name.
  2. Your sentences appear to all be on a separate line, is there some reason to not have them on the same line and let MkDocs figure out the wrapping?

Q(description__icontains=value)
)
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things that I think are worth mentioning:

  1. NetBoxModelFilterSet.search() is already implemented and just returns the queryset unmodified, which is why it needs to be over-ridden here.
  2. For context, the search() method is called as a result of the q filter, which is already wire up in NetBoxModelFilterSet and does not need to be over-ridden here unless different behavior is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I incorporated your comments in 6593f1b

@991jo
Copy link
Contributor Author

991jo commented Oct 21, 2025

Regarding each sentence being on it's own line: That's mainly a convention I am sticking to, because it makes changes in diffs clearer, because you only get 1 sentence highlighted instead of the whole paragraph.

Regarding the control of linebreaks: It is complicated. This is primarily an issue of Markdown. CommonMark (an attempt at a markdown spec) seperates a paragraph only if there is a blank line inbetween (see https://spec.commonmark.org/0.31.2/#paragraphs ).
There could be explicit line breaks with two spaces at the end of the line (https://spec.commonmark.org/0.31.2/#hard-line-breaks)

For me this generates one <p> elememt:

<p>The <code>ObjectListView</code> has a field called Quick Search.
For Quick Search to work the corresponding FilterSet has to implement the <code>search</code> method.
This function takes a queryset and can perform arbitrary operations on it and return it.
A common use-case is to search for the given search value in multiple fields:</p>

-> there is no special line break handling in mkdocs afaik and it's all HTML or whatever the other output options of mkdocs are.
However I am also fine with putting the whole paragraph on one line to match the style of the remaining document.

@jnovinger jnovinger self-requested a review October 21, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Plugins development documentation does not explain the ObjectListView quick search function.

2 participants