Closes: #19200 Add Virtual Chassis name to pane on Device View #19369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatoalmeidaoliveira
requested review from
a team and
jeremystretch
and removed request for
a team
|
|
jeremystretch
requested changes
May 2, 2025
| @@ -26,6 +26,12 @@ <h2 class="card-header">{% trans "Device" %}</h2> | |||
| <th scope="row">{% trans "Location" %}</th> | |||
| <td>{% nested_tree object.location %}</td> | |||
| </tr> | |||
| {% if vc_members %} | |||
There was a problem hiding this comment.
This should be conditional on the value of object.virtual_chassis, rather than vc_members.
Comment on lines
+30
to
+33
| <tr> | ||
| <th scope="row">{% trans "Virtual Chassis" %}</th> | ||
| <td>{{ object.virtual_chassis|linkify }}</td> | ||
| </tr> |
There was a problem hiding this comment.
Remember to indent code within {% if %} blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #19200 Add Virtual Chassis name to pane on Device View
Devicecard.Observations
When I added that data to the
Virtual Chassiscard, it looked very different from the general UI. I mean, users normally don't expect to see a device name in the card header.If I add that information there to follow the usual behavior, I should add it as a clickable link. However, this would be redundant, considering the
View Virtual Chassislink already present in that pane.So, adding that information in the
Devicecard next to theRackinformation makes more sense to me.