Fix HPE Aruba 8325 Bundle SKU, added HPE Aruba 8325 Power Supplies and Fans #3246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Devices that have removal PSUs and Fans should have those modeled at Module-bays, even if they come as a bundle from the manufacturer. Having the bundles as separate devices to the standard chassis seems like a lot of duplication within this repo, I would recommend we keep it as the 1 new device that you have created with the modules and remove the bundle devices. |
harryajc
added
the
status: revisions needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing 8325 models had the SKUs from the bundles (with fans and power supplies).
I have completed the bundle specification and added the specification for the standalone SKUs.
I also added the power supply and fan models for the 8325s.