Expose additional variables to select policies in Fabric Pod Policy Group #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roup. Fix for terraform-aci-fabric-pod-policy-group "Please add all options to edit" netascode#175 M: defaults.yaml M: aci_fabric_policies.tf M: terraform-aci-fabric-pod-policy-group
|
Custom route reflector, ISIS, and COOP policies cannot be created (there is only the system default), and these do not need to be specified in the pod policy group. Even though technically you could specify "default", it gets applied without doing so. Therefore it only makes sense to add the ability to configure a MACsec policy. This is not yet possible in the module, so perhaps you could consider adding a module for that in conjunction with being able to set it in the pod policy group? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #175 Expose additional fields/variables
M: defaults.yaml
M: aci_fabric_policies.tf
M: terraform-aci-fabric-pod-policy-group