APIC 4.x/5.x Interface shutdown Support #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andbyrne
requested changes
Oct 22, 2024
There was a problem hiding this comment.
At the moment this code will generate a resource for every defined port which may be undesirable. It would be better to rename the module to terraform-aci-interface-shutdown and to only pass it ports that need to be blacklisted.
i.e. There's no need for a shutdown variable to be passed to the module. It should assume that any provided port should be blacklisted.
andbyrne
requested changes
Oct 23, 2024
devegupt
changed the title
devegupt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the enhancement to support the port shutdown operation on APIC 4.x/5.x while using "new_interface_configuration: false"