Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort library and sub-app names to reduce git merge conflicts #1957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xpol
Copy link

@xpol xpol commented Dec 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1956

What is the new behavior?

Sort library name and sub app names in:

  • projects of the nest-cli.json
  • compilerOptions.path of the tsconfig.json
  • jest.moduleNameMapper of the package.json

to reduce git merge conflicts

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@xpol xpol force-pushed the feat-1956-sort-apps-and-libs branch 6 times, most recently from 1c32877 to f23f3c1 Compare December 9, 2024 07:46
@xpol xpol force-pushed the feat-1956-sort-apps-and-libs branch from f23f3c1 to 797a384 Compare December 9, 2024 07:50
@xpol xpol changed the title feat: sort library and sub-app names to reduce git conflicts feat: sort library and sub-app names to reduce git merge conflicts Dec 9, 2024
@xpol
Copy link
Author

xpol commented Dec 12, 2024

Any updates?

@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Dec 12, 2024

We're going to wait to merge this PR till the next major release (which is scheduled to be published in the next few weeks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants