feat(microservices): implement preRequest message/event handler #8455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3a1d49a7-0da4-4b79-8b2e-2e474bd6ab79
💛 - Coveralls |
micalevisk
reviewed
Apr 12, 2022
| @@ -29,4 +29,11 @@ export class NestApplicationContextOptions { | |||
| * @default true | |||
| */ | |||
| autoFlushLogs?: boolean; | |||
|
|
|||
| /** | |||
| * @desc A token for a Class, that will be called per each message received | |||
There was a problem hiding this comment.
Suggested change
| * @desc A token for a Class, that will be called per each message received | |
| * A token for a Class, that will be called per each message received |
to keep consistent with the codebase
|
i wonder why this pr is closed? |
|
@xuzaixian This implementation has several downsides and doesn't provide functionalities & capabilities that are described in the original issue #1627 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1627
What is the new behavior?
Added
preRequesthandler for such cases.Does this PR introduce a breaking change?
Other information
I am not really sure at the moment how I could test it and where I should write documentation for that, I wonder if someone could point me to the right direction?