-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Improve middleware route exclusion for dynamic endpoints #14194
base: master
Are you sure you want to change the base?
fix(core): Improve middleware route exclusion for dynamic endpoints #14194
Conversation
Pull Request Test Coverage Report for Build b72c5f50-710a-40ab-86ee-2547082376ebDetails
💛 - Coveralls |
Could you also add an integration test? |
Yes, I can |
Integration tests have been completed @kamilmysliwiec |
@kamilmysliwiec Can this be merged? 😭 |
We need to be very careful when making any changes to the middleware exclusion algorithm as they will certainly affect many users of the framework. Might need to wait with this change till the next major release |
ok, I understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge nestjs:master
into sapenlei:fix/Express-Middleware-not-being-called-for-some-endpoints
. All checks passed
fixes #13593
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #13593
What is the new behavior?
The middleware route exclusion now correctly handles the coexistence of static and dynamic routes:
For example, when excluding /:id route:
Does this PR introduce a breaking change?
Other information