fix(core): always bind global modules when scan for modules #12880
+57
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
packages/core/scanner.ts
Outdated
| if (this.isForwardReference(moduleDefinition)) { | ||
| moduleDefinition = (moduleDefinition as ForwardReference).forwardRef(); | ||
| const moduleInstance = await this.insertModule(moduleDef, scope); | ||
| this.container.bindGlobalsToImports(moduleInstance); |
There was a problem hiding this comment.
bindGlobalsToImports should be called only for lazy modules.
There was a problem hiding this comment.
Will create parameter whether modules bind to global
|
Could you create release branch for 9.x so this branch merged? |
|
Just fyi, in case you're blocked by this change you can always use |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mehmetik
approved these changes
Dec 29, 2023
benjGam
approved these changes
Jan 17, 2024
|
@5d-jh can you please rebase your branch |
|
@micalevisk Because this pr resolves issue on v9, this pr should be merged into v9 release branch which is currently not exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #12879
What is the new behavior?
Scanning for modules always bound for global modules,
Does this PR introduce a breaking change?
Other information
This branch is based on 9.4.3. Hence should not be merged into master.