Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: federation schema builder #2059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

endroca
Copy link

@endroca endroca commented Mar 4, 2022

Referer: #1780

## PR Checklist
Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1597

What is the new behavior?

The generated schema contains also the directives needed for the federation.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andrius0124
Copy link

@kamilmysliwiec
Thanks for the great framework!
Anyway we could speed up this PR?
It's a blocker for us.

@endroca
Copy link
Author

endroca commented Mar 30, 2022

@kamilmysliwiec Thanks for the great framework! Anyway we could speed up this PR? It's a blocker for us.

@Andrius0124 A temporary solution that i am using in my projects

      transformSchema: (schema) => {
        writeFileSync(
          join(process.cwd(), 'src/schema.gql'),
          printSubgraphSchema(schema),
        );
        return schema;
      },

I hope it helps

@Andrius0124
Copy link

@endroca Huge help! Works like a charm! Thanks

@Francismb
Copy link

Looking forward to it!

@mandajoan
Copy link

Hello! Ran into this issue and journeyed along the various issues reported to end up on this PR. Any updates on the status of this getting merged or input on new solutions w/the more recent package updates?

@renanpupin
Copy link

I can confirm this is still a problem.

@jasonmacdonald
Copy link

This is a 3 year old issue that has a simple fix and yet still isn't addressed. This completely breaks using Nest with code-first and federation 2. I'm so confused about how this is just lingering.

@nestjs nestjs locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants