Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fundamentals): reword the default behavior of ModuleRef#get #3045

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Jun 27, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

Current behavior

it doesn't seems too clear that ModuleRef#get by default won't found providers registered and exported by imported modules

What is the new behavior?

https://deploy-preview-3045--docs-nestjs.netlify.app/fundamentals/module-ref#retrieving-instances

help to avoid confusion as this one: nestjs/nest#13726

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit af9c43a into nestjs:master Jul 1, 2024
4 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

@micalevisk micalevisk deleted the patch-2 branch July 1, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants