This repository has been archived by the owner on Aug 13, 2021. It is now read-only.
[215] health scanner unify ES #216
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindrones
reviewed
Jan 23, 2020
| "nih": "placeName_country_organisation" | ||
| }, | ||
| "country_id": { | ||
| TODO: iso2, iso3 or isoNumeric. Pick one? |
There was a problem hiding this comment.
Yes. iso2 as it's the shortest?
| "meetup": "terms_mesh_group", | ||
| "nih": "terms_mesh_abstract" | ||
| }, | ||
| "sdg_labels": { |
There was a problem hiding this comment.
I think this should be terms_sdg to signify this is an array of strings, or we can change the convention and use array_* if terms is too specific for some keys?
| }, | ||
| "funding_entity": { | ||
| "nih": "title_of_funder" | ||
| }, |
There was a problem hiding this comment.
I think this comma will give an error
| "title": { | ||
| "nih": "title_of_project" | ||
| }, | ||
| "start_date": { |
There was a problem hiding this comment.
I changed my mind, I think we should use date_* for time related keys:
date_startdate_enddate_update
| "update_date": { | ||
| "crunchbase": "datetime_updated_organisation" | ||
| }, | ||
| "continent": { |
There was a problem hiding this comment.
also I wanted to propose a geo_* namespace as we'd also have funding_*, terms|array_*, url_*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#215