Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added attached volume based mounting #228

Merged
merged 2 commits into from
Nov 26, 2024
Merged

added attached volume based mounting #228

merged 2 commits into from
Nov 26, 2024
+70 −6

Conversation

Milstein
Copy link
Contributor

No description provided.

joachimweyl
joachimweyl approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@joachimweyl joachimweyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine but I noticed on line 109 we have a mistake
You can also tweak the file permissions to your preference. Here's we have given
Here's should be Here

@Milstein Milstein merged commit 14253ae into main Nov 26, 2024
4 checks passed
@Milstein Milstein deleted the nfs_with_volume branch November 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachimweyl joachimweyl joachimweyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Milstein @joachimweyl