Refactor service configuration tasks and vardefs

.github/workflows/libvirt.yml

@@ -10,7 +10,6 @@ jobs:
   libvirt:
     name: libvirt
     runs-on: libvirt
-    needs: version
     strategy:
       matrix:
         scenario:

defaults/main.yml

@@ -9,14 +9,12 @@ docker_rpm_repo:
 docker_repo_state: present
 docker_repo_manage: "{{ docker_packages_state != 'absent' }}"
 
+docker_packages_state: present
 docker_packages:
   - docker-ce
   - docker-ce-cli
 
-docker_packages_state: present
-docker_configuration_template: mountflags.conf.j2
-docker_configuration_file: /etc/systemd/system/docker.service.d/mountflags.conf
-docker_configuration_path: "{{ docker_configuration_file | dirname }}"
+docker_service_confdir: /etc/systemd/system/docker.service.d
 docker_service_name: docker
 docker_service_state: started
 docker_service_enabled: true
@@ -33,4 +31,4 @@ docker_conf:
   log-opts:
     max-size: "10m"
     max-file: '3'
-  registry-mirrors: "{{ docker_conf_mirrors }}"
+  registry-mirrors: "{{ docker_conf_mirrors }}"  # see https://docs.docker.com/docker-hub/mirror/#configure-the-docker-daemon

tasks/main.yml

@@ -48,10 +48,9 @@
 - name: Configure service
   when: docker_packages_state != 'absent'
   block:
-
     - name: Configure service path
       ansible.builtin.file:
-        path: "{{ docker_configuration_path }}"
+        path: "{{ docker_service_confdir }}"
         state: directory
         group: root
         owner: root
@@ -62,20 +61,23 @@
       when: docker_service_manage
       tags: install
       block:
-
         - name: Configure service
-          ansible.builtin.template:
-            src: "{{ docker_configuration_template }}"
-            dest: "{{ docker_configuration_file }}"
+          ansible.builtin.copy:
+            dest: "{{ docker_service_confdir }}/mountflags.conf"
+            content: |
+              [Service]
+              MountFlags=shared
             group: root
             owner: root
             mode: 'u=rw,go=r'
 
         - name: Include service tasks
           ansible.builtin.include_tasks: service.yml
 
+
 - name: Include configuration tasks
   ansible.builtin.include_tasks: config.yml
 
+
 - name: Include user tasks
   ansible.builtin.include_tasks: users.yml