Skip to content

FEATURE: Inline editing overhaul #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 230 commits into
base: 9.1
Choose a base branch
from
Open

FEATURE: Inline editing overhaul #4016

wants to merge 230 commits into from

Conversation

@Sebobo
Copy link
Member

@Sebobo Sebobo commented Oct 22, 2025 •
edited
Loading

  • Fully integrate CKeditor block and inline toolbars with editable properties
  • Remove React wrapping code from Neos.Ui for all editors (except link editor)
  • Cursor position dependent "Add" and "Paste" buttons
  • Position aware paste which allows skipping the insertion mode modal
  • Custom styles / CSS classes selection via yaml configuration and CK plugin
  • Inspector in full screen mode
  • New breadcrumb that replaces "Current Selection"
  • Polyfill for Firefox and older Safari version to support anchor positioning
  • Duplicate node button
  • Integrate CKEditor toolbars with RichTextEditor
  • Inline table editor with caption support
  • Still support old style editor plugins
  • Improved content collection overlay
  • Integrate and adjust CKEditor theme
  • Style detail adjustments
  • Toolbar configuration via YAML (not urgent, maybe for 9.2)
  • Update CKEditor from 44 to 46 for improved performance and bug fixes

pKallert and others added 30 commits December 22, 2023 12:40
@pKallert
Feature: Add basic colors to dimensions dropdown
e5bdcdb
@pKallert
Feature: Add for single dimensions
afd89aa
@pKallert
Feature: Add logic for twodimensional dropdown
97c025f
@markusguenther
TASK: Fix linting issues
b838ab8
@pKallert
Feature: make linking only work with single dimension
c441ff6
@pKallert
Merge branch '8.4' into feature/AddInactiveContentDimensionsDropdown
a04c2a3
@pKallert
Feature: Add URL option for single dropdown
d048232
@pKallert
Feature: Resolve Merge conflict
639b6cd
@pKallert
Feature: update styling
777e6d0
@pKallert
FIX: Linter
9d0061a
@pKallert
Feature: Make Link full width of line
76c0299
@pKallert
Feature: add styling
a0eb7a6
@pKallert
Feature: Add title attribute to explain colors
1c0c381
@pKallert
Fix: fix linting errors
563c79c
@pKallert @Sebobo
Fix: Adjust spacing for CSS changes
db85185 
Co-authored-by: Sebastian Helzle <[email protected]>
@pKallert
Fix: Adjust naming from existing to covered
ff75dd4
@pKallert
Merge branch 'feature/AddInactiveContentDimensionsDropdown' of https:…
773b30d 
…//github.com/pKallert/neos-ui into feature/AddInactiveContentDimensionsDropdown
@pKallert
Fix: resolve merge conflict with 8.4 branch
76e3b6c
@pKallert
Merge branch '8.4' into feature/AddInactiveContentDimensionsDropdown
3cb7116
@pKallert
Resolve merge conflicts
6510a0c
@mhsdesign
TASK: Dont compile ts when linting typescript via yarn tsc
3d314b0
@mhsdesign
BUGFIX: createAttributeElement is not a function
64b1e0d 
with the ckeditor update #3883 we have to adjust this
@Sebobo
BUGFIX: Skip content childnodes when rendering document tree nodes
8cc1292
@pKallert
Merge branch '8.4' into feature/AddInactiveContentDimensionsDropdown
ca91156
@pKallert
Feature: remove componentDidMount
318f860
@Sebobo
TASK: Fix styleci issues
941fc1b
@Sebobo
BUGFIX: Adjust filter rendering nodes with parents
3074655
@Sebobo
TASK: Adjust getForTree queries to have the same payload structure
5fbb7cb
@laurahaenel
BUGFIX: add CKEditor Heading Plugin for p, pre, blockquote
700c226
@laurahaenel
BUGFIX: add CKEditor Heading Plugin for p, pre, blockquote
6874aab
Sebobo added 15 commits October 29, 2025 09:42
@Sebobo
BUGFIX: Let ckeditor ignore neos specific drag events
905ff39 
CKEditor catches all drag events so we cannot handle them ourselves.
With this patch it ignores the ones with a neos type
@Sebobo
TASK: Improve drop indicator layout
6637605
@Sebobo
TASK: Add missing methods to NodeTypesRegistry interface
0488884
@Sebobo
TASK: Move dragndrop functionality into a single guest frame component
8f2d5bb
@Sebobo
TASK: Adjust drag button to new toolbar layout
1763ece
@Sebobo
TASK: Improve CK toolbar styling
0c3c747
@Sebobo
TASK: Use new hook to access redux store
e97dd39
@Sebobo
TASK: Remove ck inline editor border
90817f7
@Sebobo
FEATURE: Enable table caption plugin
7cf1c83
@Sebobo
FEATURE: Make editable area visible without visual jumping due to border
ad6701a
@Sebobo
TASK: Allow selectable CK styles in formatting proptypes
7c1d4d1
@Sebobo
TASK: Reduce visual clutter in breadcrumb
53cecb6
@Sebobo
TASK: Make empty collection overlay lighter
2dbe108
@Sebobo
BUGFIX: Prevent unfocus events during inline editing
47f300c 
Keep the Neos UI and CKEditor from unfocusing our currently edited node
or editable area when we click parts of the toolbar.
@Sebobo
BUGFIX: Prevent delayed repositioning of toolbars during inline editing
45239d7 
Before it would take some time during editing when newlines are added until
the anchorposition would be recalculated due to the stored node change.
@Sebobo Sebobo force-pushed the feature/3972-node-toolbars branch from 91f1184 to 45239d7 Compare October 29, 2025 08:43
@Sebobo Sebobo self-assigned this Nov 5, 2025
@Sebobo Sebobo moved this to In progress in Neos 9.1 Release Board Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Sebobo Sebobo

Labels

9.1 Feature Label to mark the change as feature UI & UX

Projects

Neos 9.1 Release Board
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.