-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Switch Mink extension #32
Conversation
The original package is about to be marked as abandoned, see Behat/MinkExtension#370 (comment) Lock file operations: 2 installs, 26 updates, 13 removals - Removing behat/mink-browserkit-driver (v1.3.4) - Removing behat/mink-extension (2.3.1) - Removing behat/mink-goutte-driver (v1.2.1) - Removing fabpot/goutte (v3.3.1) - Removing guzzlehttp/guzzle (6.5.5) - Removing guzzlehttp/promises (1.4.0) - Removing guzzlehttp/psr7 (1.7.0) - Removing psr/http-message (1.0.1) - Removing ralouphie/getallheaders (3.0.3) - Removing symfony/browser-kit (v4.4.17) - Removing symfony/dom-crawler (v4.4.17) - Removing symfony/polyfill-intl-idn (v1.20.0) - Removing symfony/polyfill-php72 (v1.20.0) - Upgrading behat/behat (v3.8.1 => v3.13.0) - Upgrading behat/gherkin (v4.6.2 => v4.9.0) - Upgrading behat/mink (v1.8.1 => v1.10.0) - Upgrading behat/mink-selenium2-driver (v1.4.0 => v1.6.0) - Upgrading behat/transliterator (v1.3.0 => v1.5.0) - Locking friends-of-behat/mink-extension (v2.7.2) - Upgrading instaclick/php-webdriver (1.4.7 => 1.4.16) - Upgrading psr/container (1.0.0 => 1.1.2) - Upgrading symfony/config (v4.4.17 => v5.4.21) - Upgrading symfony/console (v5.2.0 => v5.4.24) - Upgrading symfony/css-selector (v5.2.0 => v5.4.21) - Upgrading symfony/dependency-injection (v4.4.17 => v5.4.24) - Upgrading symfony/deprecation-contracts (v2.2.0 => v2.5.2) - Upgrading symfony/event-dispatcher (v5.2.0 => v5.4.22) - Upgrading symfony/event-dispatcher-contracts (v2.2.0 => v2.5.2) - Upgrading symfony/filesystem (v5.2.0 => v5.4.23) - Upgrading symfony/polyfill-ctype (v1.20.0 => v1.27.0) - Upgrading symfony/polyfill-intl-grapheme (v1.20.0 => v1.27.0) - Upgrading symfony/polyfill-intl-normalizer (v1.20.0 => v1.27.0) - Upgrading symfony/polyfill-mbstring (v1.20.0 => v1.27.0) - Upgrading symfony/polyfill-php73 (v1.20.0 => v1.27.0) - Upgrading symfony/polyfill-php80 (v1.20.0 => v1.27.0) - Locking symfony/polyfill-php81 (v1.27.0) - Upgrading symfony/service-contracts (v2.2.0 => v2.5.2) - Upgrading symfony/string (v5.2.0 => v5.4.22) - Upgrading symfony/translation (v4.4.17 => v5.4.24) - Upgrading symfony/translation-contracts (v2.3.0 => v2.5.2) - Upgrading symfony/yaml (v5.2.0 => v5.4.23)
@@ -1,8 +1,7 @@ | |||
{ | |||
"require": { | |||
"behat/behat": "^3.5", | |||
"behat/mink-extension": "^2.3", | |||
"behat/mink-goutte-driver": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you do this, then you will end up running all tests with selenium, which is so damn slow that it hurts. See my comment in #33 with a solution to replace "goutte" with "browserkit" for a pure PHP browser implementation. This way test suites which do not require @javascript
run very fast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also: don't forget to also adapt the behat.yml.dist
to remove goutte (and maybe add browserkit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I probably mistook the dev dependency of friends-of-behat/mink-extension
on behat/mink-goutte-driver
for a regular one and wanted to remove a transitional dependency.
We dont recommend behat/mink-extension anymore and this package was cleaned up with 9.0 |
The original package is about to be marked as abandoned, see Behat/MinkExtension#370 (comment)
See #33