feat(proxy): add batching to cancellation queue processing #10607
+183
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7414 tests run: 7061 passed, 0 failed, 353 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
aff3fb5 at 2025-01-31T18:51:42.713Z :recycle: |
awarus
reviewed
Jan 31, 2025
proxy/src/cancellation.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| // Running as a separate task to accept messages through the rx channel | ||
| // In case of problems with RTT: switch to recv_many() + redis pipeline |
There was a problem hiding this comment.
now we can remove this line :)
awarus
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently deployed the cancellation queue.
The size of the queue makes me uncomfortable so I'd like to implement batching+pipelining ASAP.The queue size seems fine. I read the graphs wrong.