Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use substitution in the testframework mod metadata #1221

Merged

Conversation

Matyrobbrt
Copy link
Member

Fixes #983

@Matyrobbrt Matyrobbrt added bug A bug or error 1.21 Targeted at Minecraft 1.21 labels Jul 3, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 3, 2024

  • Publish PR to GitHub Packages

Last commit published: 94792fa094bf4d474060486f03e63d2289df7ee4.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1221' // https://github.com/neoforged/NeoForge/pull/1221
        url 'https://prmaven.neoforged.net/NeoForge/pr1221'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1221.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1221
cd NeoForge-pr1221
curl -L https://prmaven.neoforged.net/NeoForge/pr1221/net/neoforged/neoforge/21.0.59-beta-pr-1221-testframework-use-jar-version/mdk-pr1221.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should investigate why this is different from the other projects. NeoForge and tests do run correctly?

@Matyrobbrt Matyrobbrt merged commit 79de679 into neoforged:1.21.x Jul 5, 2024
6 checks passed
@Matyrobbrt Matyrobbrt deleted the testframework-use-jar-version branch July 5, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Targeted at Minecraft 1.21 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests subproject's GameTestServer cannot be run in Eclipse debug mode
3 participants