Add Item Abilities for lighting and dowsing

[HenryLoenwind]

Implements #1179 by adding an ItemAbility for Flint&Steel to light candles, cake with candles and campfires. Also adds an ItemAbility for the reverse, i.e. for shovels to dowse campfires.

Edit: And FireCharge and dispenser using Flint&Steel.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[RaymondBlaze]

The dowsing item ability seems fine to me, however the lighting item ability didn't got fire charge included.
Note that flint and steel may also be used to light blocks using dispenser, a patch to DispenseItemBehavior is also needed for consistency.

[sciwhiz12]

Wouldn't the proper term here be "dousing"? At the very least, that would be the more common spelling, and it would risk less confusion with the divination practice of dowsing.

[HenryLoenwind]

Wouldn't the proper term here be "dousing"? At the very least, that would be the more common spelling, and it would risk less confusion with the divination practice of dowsing.

The vanilla name is CampfireBlock.dowse(); I kept that for consistency. (And because I had no reason to look up the spelling. Neither dowse nor douse are words I do anything with but recognise them when I read them...)

[TelepathicGrunt]

Sometime mojang typos lol. We should do correct spelling imo

[HenryLoenwind]

While I don't think the definition is that clear, with even the Uk parliament using dowsing and some dictionaries listing it as variant spelling, I have no attachment to that name and will change it.

PS: For reference (i.e. to save myself from having to search again and again):

[TelepathicGrunt]

hmm if we are going to have confusion over the word, is there an alternative word we can use for unlighting?

[Ezelsorix]

how about extinguish^^? That's what I would have went with anyway before we have a 1984 moment (and actually call it unlighting^^) ...

[HenryLoenwind]

how about extinguish^^? That's what I would have went with anyway before we have a 1984 moment (and actually call it unlighting^^) ...

While there's some precedence (mc has "Candle extinguishes" as subtitle), I would prefer to not use words people generally use when talking about FireBlock fires when talking about actions on blocks that can be "turned on and off".