-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.x] TODOs and NBT cleanup for entities #1166
base: 1.21.x
Are you sure you want to change the base?
[1.21.x] TODOs and NBT cleanup for entities #1166
Conversation
robotgryphon
commented
Jun 22, 2024
- Deprecates persistent data (use data attachments)
- Deprecates INBTSerializer for entities (data attachments/workarounds)
- Method renames for the 1.19 world -> level change
Last commit published: ccc630a88211b870383303bfaba5ea860b57bd9d. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1166' // https://github.com/neoforged/NeoForge/pull/1166
url 'https://prmaven.neoforged.net/NeoForge/pr1166'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1166
cd NeoForge-pr1166
curl -L https://prmaven.neoforged.net/NeoForge/pr1166/net/neoforged/neoforge/21.0.52-beta-pr-1166-feature-nbt-entity-cleanup/mdk-pr1166.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
I believe that there are some uses cases for entity persistent data, for example marking item entities that should not be picked up by magnets, and other similar cases of mod compat. I agree with the other changes. |
You'd rather keep persistent data when attachments exist, for stuff like magnet control? That feels like a capability or attachment thing.. persistent data is like using a sword when you have a scalpel nearby. |
@robotgryphon, this PR introduces breaking changes.
|
* @deprecated Use {@link #onAddedToLevel()} instead. | ||
*/ | ||
@Deprecated(forRemoval = true, since = "21.0") | ||
default void onAddedToWorld() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really need to stay around as baggage? NeoForge's still in the breaking-changes phase of 1.21.