Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null player for UseItemOnBlockEvent #1150

Open
wants to merge 4 commits into
base: 1.21.x
Choose a base branch
from

Conversation

TelepathicGrunt
Copy link
Contributor

Resolves some todo comments we had leftover. Reason for this change is because DirectionalPlaceContext has player set to null and modders could pass that to our event. Now we make UseItemOnBlockEvent a bit more lenient and can accept null players

@TelepathicGrunt TelepathicGrunt added enhancement New (or improvement to existing) feature or request 1.21 Targeted at Minecraft 1.21 labels Jun 20, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this Jun 20, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 20, 2024

  • Publish PR to GitHub Packages

Last commit published: 625ca47c99814593de80860336ac15b68e0d4da1.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1150' // https://github.com/neoforged/NeoForge/pull/1150
        url 'https://prmaven.neoforged.net/NeoForge/pr1150'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1150.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1150
cd NeoForge-pr1150
curl -L https://prmaven.neoforged.net/NeoForge/pr1150/net/neoforged/neoforge/21.0.45-beta-pr-1150-PlayerInteractSupportNullablePlayer/mdk-pr1150.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Jun 26, 2024

@TelepathicGrunt, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 625ca47c99814593de80860336ac15b68e0d4da1.

neoforge (:neoforge)

  • net/neoforged/neoforge/event/entity/player/UseItemOnBlockEvent
    • ❗ Class missing superclass of net/neoforged/neoforge/event/entity/player/PlayerInteractEvent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Targeted at Minecraft 1.21 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants