Fix inconsistent typing of duration properties #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxAake
force-pushed
the
fix-integer-conversion-with-configs
branch
from
967c612 to
f433d5c
Compare
robsdedude
reviewed
Jun 5, 2025
packages/core/src/temporal-types.ts
Outdated
| @@ -79,6 +79,14 @@ export class Duration<T extends NumberOrInteger = Integer> { | |||
| * @type {NumberOrInteger} | |||
| */ | |||
| this.nanoseconds = util.normalizeNanosecondsForDuration(nanoseconds) as T | |||
| if (typeof this.months === 'number' && isInt(this.nanoseconds) && isInt(this.seconds)) { | |||
There was a problem hiding this comment.
What if Duration is constructed with Duration(someNumber, someInteger, someBigint). I mean it's really ugly and the types state that this is not supported. But
- In JS (not TS), nothing is strongly typed
- This if is already covering the use-case of mixing different number types.
There was a problem hiding this comment.
It's not the biggest issue, since the packer would handle that just fine, but there's always a change that a user does something odd and creates a duration object for their own use somewhere. I'm making a change so that the normalized seconds and nanos will keep the same type as the unnormalized values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Duration the seconds and nanoseconds will be converted to Integers, no matter if provided with Integers, Numbers, or BigInts. This is awkward and requires special handling by users